WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] get_current() called before set_current()

To: "Charles Coffing" <ccoffing@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] get_current() called before set_current()
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 31 Aug 2004 20:41:38 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 31 Aug 2004 20:54:55 +0100
Envelope-to: steven.hand@xxxxxxxxxxxx
In-reply-to: Your message of "Tue, 31 Aug 2004 13:19:37 MDT." <s1347af8.043@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
Thanks, I've checked it in.

It's interesting that noone in Cambridge saw the problem when using a
debug build. My guess is that we only ever momentarily cycle the power
on our test boxes, and the stack happens to live in an area of memory
untouched by our boot process. :-)

 -- Keir

> The recent change that added debugging to spinlocks (cset 1.1278.1.1)
> caused get_current() to be called earlier in the boot process.  In fact,
> it is now called before set_current().
> 
> If assertions are compiled in, this ultimately causes a triple fault
> when Xen tries to print the banner.  If assertions aren't compiled in,
> memory corruption results (although currently this corruption appears to
> be benign.)
> 
> The attached patch moves the first set_current() call a bit earlier in
> the boot process.


-------------------------------------------------------
This SF.Net email is sponsored by BEA Weblogic Workshop
FREE Java Enterprise J2EE developer tools!
Get your free copy of BEA WebLogic Workshop 8.1 today.
http://ads.osdn.com/?ad_id=5047&alloc_id=10808&op=click
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel

<Prev in Thread] Current Thread [Next in Thread>