This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [Patch] Always call blkdev_put when destroying a vbd in devi

To: xen-devel@xxxxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [Patch] Always call blkdev_put when destroying a vbd in device backend
From: Michael Vrable <mvrable@xxxxxxxxxxx>
Date: Fri, 27 Aug 2004 16:36:22 -0700
Delivery-date: Sat, 28 Aug 2004 00:40:31 +0100
Envelope-to: steven.hand@xxxxxxxxxxxx
List-archive: <http://sourceforge.net/mailarchive/forum.php?forum=xen-devel>
List-help: <mailto:xen-devel-request@lists.sourceforge.net?subject=help>
List-id: List for Xen developers <xen-devel.lists.sourceforge.net>
List-post: <mailto:xen-devel@lists.sourceforge.net>
List-subscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=subscribe>
List-unsubscribe: <https://lists.sourceforge.net/lists/listinfo/xen-devel>, <mailto:xen-devel-request@lists.sourceforge.net?subject=unsubscribe>
Mail-followup-to: xen-devel@xxxxxxxxxxxxxxxxxxxxx
Sender: xen-devel-admin@xxxxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
The code for the block backend device in XenoLinux doesn't call
blkdev_put on all code paths that can destroy a vbd.  Previously,
blkdev_put was only called from vbd_shrink.  I've added the call to
vbd_destroy and destroy_all_vbds.

With the old code, the kernel running in domain-0 would believe the
devices exported to another domain to still be in use, even after the
other domain was shutdown.  (This was obvious when using LVM, since the
logical volumes were still listed as open, and a warning message was
printed when shutting down LVM.)  This patch should fix that.

--Michael Vrable

Attachment: blkdev-backend.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>