WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-cim

Re: [Xen-cim] Patch for review

To: "Szymanski, Lukasz K" <Lukasz.Szymanski@xxxxxxxxxx>
Subject: Re: [Xen-cim] Patch for review
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Wed, 31 May 2006 19:33:38 -0600
Cc: xen-cim@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 31 May 2006 18:33:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <94C8C9E8B25F564F95185BDA64AB05F6039C9DD1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-cim-request@lists.xensource.com?subject=help>
List-id: xen-cim mailing list <xen-cim.lists.xensource.com>
List-post: <mailto:xen-cim@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-cim>, <mailto:xen-cim-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-cim>, <mailto:xen-cim-request@lists.xensource.com?subject=unsubscribe>
References: <94C8C9E8B25F564F95185BDA64AB05F6039C9DD1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-cim-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0 (X11/20041206)
Szymanski, Lukasz K wrote:

Hello All -

This patch adapts Raj's Xen_HostedComputerSystem patch to other Xen_Hosted* files:

Xen_HostedDisk.mof, Xen_HostedDisk.c, Xen_HostedProcessor.mof, Xen_HostedProcessor.mof, Xen_HostedMemory.mof, Xen_HostedMemory.c, Xen_HostedNetworkPort.mof, Xen_HostedNetworkPort.c


The problem with this patch, and Raj's previous one apparently :-), is that there is no filtering of object paths returned via upcalls to cimom for instance names of the associated thing. For example, in ReferenceNames() in Xen_HostedMemory.c we make an upcall to get all instances of CIM_Memory when it is the target class. But Xen_Memory is a subclass of CIM_Memory so you get instances of Xen_Memory (which is the source class) and associate it with itself or other instances of Xen_Memory for other domains. If I list associations of Xen_Memory for domain 1 using this patch, I get a Xen_HostedMemory association for each Xen_Memory object produced by other domains.

Make sense?  I'm quite tired now so this may be a smoked explanation :-).

Thanks,
Jim


_______________________________________________
Xen-cim mailing list
Xen-cim@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-cim

<Prev in Thread] Current Thread [Next in Thread>