[Xen-changelog] [xen-unstable] bitmap_scnlistprintf() should always zero-terminate its output buffer

[Xen patchbot-unstable <patchbot@xxxxxxx>]

# HG changeset patch
# User Jan Beulich <jbeulich@xxxxxxxx>
# Date 1315388215 -3600
# Node ID ba75234a6f56ec349af46edec5dfae2fbb998976
# Parent  5fe770c8a8a35c58893816ee6335a90ed43f3bbd
bitmap_scnlistprintf() should always zero-terminate its output buffer

... as long as it has non-zero size. So far this would not happen if
the passed in CPU mask was empty.

Also fix the comment describing the return value to actually match
reality.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---


diff -r 5fe770c8a8a3 -r ba75234a6f56 xen/common/bitmap.c
--- a/xen/common/bitmap.c       Tue Sep 06 15:49:40 2011 +0100
+++ b/xen/common/bitmap.c       Wed Sep 07 10:36:55 2011 +0100
@@ -363,9 +363,8 @@
  * the range.  Output format is compatible with the format
  * accepted as input by bitmap_parselist().
  *
- * The return value is the number of characters which would be
- * generated for the given input, excluding the trailing '\0', as
- * per ISO C99.
+ * The return value is the number of characters which were output,
+ * excluding the trailing '\0'.
  */
 int bitmap_scnlistprintf(char *buf, unsigned int buflen,
        const unsigned long *maskp, int nmaskbits)
@@ -383,6 +382,8 @@
                        rbot = cur;
                }
        }
+       if (!len && buflen)
+               *buf = 0;
        return len;
 }
 EXPORT_SYMBOL(bitmap_scnlistprintf);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog