# HG changeset patch
# User Jan Beulcih <jbeulich@xxxxxxxxxx>
# Date 1308823952 -3600
# Node ID 82548feeaf8e3f74e308c74054c26992e6b6bbdd
# Parent 80fdb46627c0c319c65ab3edac2e6a4dc106e19c
xenbus: add __attribute__((format(printf... where appropriate
From: Joe Perches <joe@xxxxxxxxxxx>
Use the compiler to verify printf formats and arguments.
Fix fallout.
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
Make apply, slightly re-format, and fix more fallout (in blktap).
Signed-off-by: Jan Beulcih <jbeulich@xxxxxxxxxx>
---
diff -r 80fdb46627c0 -r 82548feeaf8e drivers/xen/blkback/xenbus.c
--- a/drivers/xen/blkback/xenbus.c Wed Jun 01 16:17:19 2011 +0100
+++ b/drivers/xen/blkback/xenbus.c Thu Jun 23 11:12:32 2011 +0100
@@ -473,7 +473,7 @@
err = xenbus_switch_state(dev, XenbusStateConnected);
if (err)
- xenbus_dev_fatal(dev, err, "switching to Connected state",
+ xenbus_dev_fatal(dev, err, "%s: switching to Connected state",
dev->nodename);
return;
diff -r 80fdb46627c0 -r 82548feeaf8e drivers/xen/blktap/xenbus.c
--- a/drivers/xen/blktap/xenbus.c Wed Jun 01 16:17:19 2011 +0100
+++ b/drivers/xen/blktap/xenbus.c Thu Jun 23 11:12:32 2011 +0100
@@ -426,7 +426,7 @@
err = xenbus_switch_state(dev, XenbusStateConnected);
if (err)
- xenbus_dev_fatal(dev, err, "switching to Connected state",
+ xenbus_dev_fatal(dev, err, "%s: switching to Connected state",
dev->nodename);
return;
diff -r 80fdb46627c0 -r 82548feeaf8e include/xen/xenbus.h
--- a/include/xen/xenbus.h Wed Jun 01 16:17:19 2011 +0100
+++ b/include/xen/xenbus.h Thu Jun 23 11:12:32 2011 +0100
@@ -276,7 +276,7 @@
* formatted message.
*/
void xenbus_dev_error(struct xenbus_device *dev, int err, const char *fmt,
- ...);
+ ...) __attribute__((__format__(__printf__, 3, 4)));
/***
@@ -285,7 +285,7 @@
* closedown of this driver and its peer.
*/
void xenbus_dev_fatal(struct xenbus_device *dev, int err, const char *fmt,
- ...);
+ ...) __attribute__((__format__(__printf__, 3, 4)));
int xenbus_dev_init(void);
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog
|
Home