WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] libxl regression: don't require vncpasswd

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] libxl regression: don't require vncpasswd when password is empty string
From: Xen patchbot-unstable <patchbot@xxxxxxx>
Date: Fri, 25 Feb 2011 21:30:10 +0000
Delivery-date: Fri, 25 Feb 2011 13:30:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Christoph Egger <Christoph.Egger@xxxxxxx>
# Date 1298056031 0
# Node ID dac86c85222e6a6b067bf7208a57d96fb3e6f57a
# Parent  d210f43decdf4ced25159b4d071493cc73030a7d
libxl regression: don't require vncpasswd when password is empty string

Don't require an empty password when the guest config file
has the entry
     vncpasswd=''

Instead, do not require a password at all in this case.

Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
Committed-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
---


diff -r d210f43decdf -r dac86c85222e tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c    Fri Feb 18 15:32:02 2011 +0000
+++ b/tools/libxl/libxl_dm.c    Fri Feb 18 19:07:11 2011 +0000
@@ -74,7 +74,7 @@
         } else {
             vncarg = "127.0.0.1:0";
         }
-        if (info->vncpasswd)
+        if (info->vncpasswd && (info->vncpasswd[0] != '\0'))
             vncarg = libxl__sprintf(gc, "%s,password", vncarg);
         flexarray_append(dm_args, "-vnc");
         flexarray_append(dm_args, vncarg);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] libxl regression: don't require vncpasswd when password is empty string, Xen patchbot-unstable <=