WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] x86: suppress HPET broadcast initializati

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: suppress HPET broadcast initialization in the presence of ARAT
From: Xen patchbot-unstable <patchbot@xxxxxxx>
Date: Fri, 11 Feb 2011 06:20:20 -0800
Delivery-date: Fri, 11 Feb 2011 06:22:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir@xxxxxxx>
# Date 1297347594 0
# Node ID a0ef80c9926462bbef8ac81b362a5f2e22b1ec85
# Parent  5b18a72d292a066d1c2b9fff7e35fc1230cdec85
x86: suppress HPET broadcast initialization in the presence of ARAT

This follows Linux commit 39fe05e58c5e448601ce46e6b03900d5bf31c4b0,
noticing that all this setup is pointless when ARAT support is there,
and knowing that on SLED11's native kernel it has actually caused S3
resume issues.

A question would be whether HPET legacy interrupts should be forced
off in this case (rather than leaving whatever came from firmware).

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
---
 xen/arch/x86/hpet.c |    3 +++
 1 files changed, 3 insertions(+)

diff -r 5b18a72d292a -r a0ef80c99264 xen/arch/x86/hpet.c
--- a/xen/arch/x86/hpet.c       Thu Feb 10 14:19:23 2011 +0000
+++ b/xen/arch/x86/hpet.c       Thu Feb 10 14:19:54 2011 +0000
@@ -557,6 +557,9 @@ void hpet_broadcast_init(void)
     u32 hpet_id, cfg;
     int i;
 
+    if ( boot_cpu_has(X86_FEATURE_ARAT) )
+        return;
+
     if ( irq_channel == NULL )
     {
         irq_channel = xmalloc_array(int, nr_irqs);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: suppress HPET broadcast initialization in the presence of ARAT, Xen patchbot-unstable <=