WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] x86: Suppress warnings about spurious pag

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: Suppress warnings about spurious pagefaults
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 04 Jun 2010 03:45:18 -0700
Delivery-date: Fri, 04 Jun 2010 03:46:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1275642270 -3600
# Node ID 88932ba626fe984ee14cb6a0d6c4629fe765f788
# Parent  99761f54183d04f00e873cd4c16fe8c66b52cb27
x86: Suppress warnings about spurious pagefaults

RHEL4 guests take a fair number of spurious pagefaults on Nehalem; no
need to report each one of them at XENLOG_WARNING.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
---
 xen/arch/x86/traps.c |   18 +-----------------
 1 files changed, 1 insertion(+), 17 deletions(-)

diff -r 99761f54183d -r 88932ba626fe xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c      Fri Jun 04 10:02:51 2010 +0100
+++ b/xen/arch/x86/traps.c      Fri Jun 04 10:04:30 2010 +0100
@@ -1175,10 +1175,7 @@ static int __spurious_page_fault(
          (l2e_get_flags(l2e) & disallowed_flags) )
         return 0;
     if ( l2e_get_flags(l2e) & _PAGE_PSE )
-    {
-        l1e = l1e_empty(); /* define before use in debug tracing */
-        goto spurious;
-    }
+        return 1;
 
     l1t = map_domain_page(mfn);
     l1e = l1e_read_atomic(&l1t[l1_table_offset(addr)]);
@@ -1188,19 +1185,6 @@ static int __spurious_page_fault(
          (l1e_get_flags(l1e) & disallowed_flags) )
         return 0;
 
- spurious:
-    dprintk(XENLOG_WARNING, "Spurious fault in domain %u:%u "
-            "at addr %lx, e/c %04x\n",
-            current->domain->domain_id, current->vcpu_id,
-            addr, error_code);
-#if CONFIG_PAGING_LEVELS >= 4
-    dprintk(XENLOG_WARNING, " l4e = %"PRIpte"\n", l4e_get_intpte(l4e));
-#endif
-#if CONFIG_PAGING_LEVELS >= 3
-    dprintk(XENLOG_WARNING, " l3e = %"PRIpte"\n", l3e_get_intpte(l3e));
-#endif
-    dprintk(XENLOG_WARNING, " l2e = %"PRIpte"\n", l2e_get_intpte(l2e));
-    dprintk(XENLOG_WARNING, " l1e = %"PRIpte"\n", l1e_get_intpte(l1e));
     return 1;
 }
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: Suppress warnings about spurious pagefaults, Xen patchbot-unstable <=