WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] x86: During cpu offline, cpu_disable_sche

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: During cpu offline, cpu_disable_scheduler() cannot fail.
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 01 Jun 2010 06:00:53 -0700
Delivery-date: Tue, 01 Jun 2010 06:02:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1275397064 -3600
# Node ID 188e3da0aa2746f2f0cecce9f099a03554755125
# Parent  50991fc8e80135d9a92b2bfc4aebd82a22dcb838
x86: During cpu offline, cpu_disable_scheduler() cannot fail.

BUG on this scenario.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/arch/x86/smpboot.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -r 50991fc8e801 -r 188e3da0aa27 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c    Tue Jun 01 11:04:08 2010 +0100
+++ b/xen/arch/x86/smpboot.c    Tue Jun 01 13:57:44 2010 +0100
@@ -858,7 +858,8 @@ void __cpu_disable(void)
     cpu_clear(cpu, cpu_online_map);
     fixup_irqs();
 
-    cpu_disable_scheduler(cpu);
+    if ( cpu_disable_scheduler(cpu) )
+        BUG();
 }
 
 void __cpu_die(unsigned int cpu)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: During cpu offline, cpu_disable_scheduler() cannot fail., Xen patchbot-unstable <=