This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: s3: write_msi_msg: entry->msg should

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: s3: write_msi_msg: entry->msg should be in the compatibility format
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 25 Mar 2010 02:35:13 -0700
Delivery-date: Thu, 25 Mar 2010 02:36:50 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1269508773 0
# Node ID e362fab06d4231eca198874edc8a14b31125a8f1
# Parent  9472f08ddd714a8427744febe39f6777e1b79645
x86: s3: write_msi_msg: entry->msg should be in the compatibility format

When Interrupt Remapping is used, after Dom0 S3, Dom0's filesystem
might become inaccessible as the SATA disk's MSI interrupt becomes
buggy.  The cause is: After set_msi_affinity() or setup_msi_irq()
invokes write_msi_msg(), entry->msg records the remappable format
message; during S3 resume, Dom0 invokes the PHYSDEVOP_restore_msi
hypercall to restore the MSI registers of devices, and in
pci_restore_msi_state() -> write_msi_msg(), the 'entry->msg' of
remappable format is passed, but in write_msi_msg() -> ... ->
msi_msg_to_remap_entry(), the 'msg' is assumed to be in compatibility
format.  As a result, after s3, the IRTE is corrupted.

Actually the only users of 'entry->msg' are pci_restore_msi_state()
and dump_msi(). That's why we don't have issue except Dom0 S3.

Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>
 xen/arch/x86/msi.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -r 9472f08ddd71 -r e362fab06d42 xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c        Thu Mar 25 07:43:09 2010 +0000
+++ b/xen/arch/x86/msi.c        Thu Mar 25 09:19:33 2010 +0000
@@ -218,6 +218,8 @@ static int set_irq_msi(struct msi_desc *
 static void write_msi_msg(struct msi_desc *entry, struct msi_msg *msg)
+    entry->msg = *msg;
     if ( iommu_enabled )
         iommu_update_ire_from_msi(entry, msg);
@@ -260,7 +262,6 @@ static void write_msi_msg(struct msi_des
-    entry->msg = *msg;
 void set_msi_affinity(unsigned int irq, cpumask_t mask)

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: s3: write_msi_msg: entry->msg should be in the compatibility format, Xen patchbot-unstable <=