This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: fix improper return value from relin

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: fix improper return value from relinquish_memory()
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 25 Mar 2010 00:55:09 -0700
Delivery-date: Thu, 25 Mar 2010 00:55:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1269502809 0
# Node ID 12aebcebff2a32c4472767bfc1577cea797777de
# Parent  377433a77d7036b17751efc8183b73b73220bfea
x86: fix improper return value from relinquish_memory()

While apparently only a theoretical possibility (domain_kill() has a
BUG_ON() that wasn't reported to trigger so far), I still think it is
better to have the code cleaned up.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
 xen/arch/x86/domain.c |    1 +
 1 files changed, 1 insertion(+)

diff -r 377433a77d70 -r 12aebcebff2a xen/arch/x86/domain.c
--- a/xen/arch/x86/domain.c     Wed Mar 24 11:06:48 2010 +0000
+++ b/xen/arch/x86/domain.c     Thu Mar 25 07:40:09 2010 +0000
@@ -1808,6 +1808,7 @@ static int relinquish_memory(
         case -EAGAIN:
         case -EINTR:
+            ret = -EAGAIN;
             page_list_add(page, list);
             set_bit(_PGT_pinned, &page->u.inuse.type_info);

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: fix improper return value from relinquish_memory(), Xen patchbot-unstable <=