[Xen-changelog] [xen-unstable] x86: kill msix_flush_writes()

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1264086780 0
# Node ID c06732ac23921ed257106b8ba582008c69b8c9f1
# Parent  57893d13574c5437aa332e44786e892f157eed22
x86: kill msix_flush_writes()

The (only) two callers of it don't need it, as the MSI-X case of
msi_set_mask_bit() already does the necessary readl().

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
---
 xen/arch/x86/msi.c |   23 -----------------------
 1 files changed, 23 deletions(-)

diff -r 57893d13574c -r c06732ac2392 xen/arch/x86/msi.c
--- a/xen/arch/x86/msi.c        Thu Jan 21 15:12:38 2010 +0000
+++ b/xen/arch/x86/msi.c        Thu Jan 21 15:13:00 2010 +0000
@@ -327,27 +327,6 @@ static void msix_set_enable(struct pci_d
     }
 }
 
-static void msix_flush_writes(unsigned int irq)
-{
-    struct msi_desc *entry = irq_desc[irq].msi_desc;
-
-    BUG_ON(!entry || !entry->dev);
-    switch (entry->msi_attrib.type) {
-    case PCI_CAP_ID_MSI:
-        /* nothing to do */
-        break;
-    case PCI_CAP_ID_MSIX:
-    {
-        int offset = PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET;
-        readl(entry->mask_base + offset);
-        break;
-    }
-    default:
-        BUG();
-        break;
-    }
-}
-
 int msi_maskable_irq(const struct msi_desc *entry)
 {
     BUG_ON(!entry);
@@ -409,13 +388,11 @@ void mask_msi_irq(unsigned int irq)
 void mask_msi_irq(unsigned int irq)
 {
     msi_set_mask_bit(irq, 1);
-    msix_flush_writes(irq);
 }
 
 void unmask_msi_irq(unsigned int irq)
 {
     msi_set_mask_bit(irq, 0);
-    msix_flush_writes(irq);
 }
 
 static struct msi_desc* alloc_msi_entry(void)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog