WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] libxenlight: don't free ifname, can lead

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] libxenlight: don't free ifname, can lead to double free
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 08 Jan 2010 04:00:33 -0800
Delivery-date: Fri, 08 Jan 2010 04:01:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1262951098 0
# Node ID 5254234fdb71d7d77910b1f86e2abfab201e7451
# Parent  5a5c2ed76aaf125beadcfc65c2a8e5450c19588e
libxenlight: don't free ifname, can lead to double free

ifname is mostly handled directly in xl now, do not attempts to free
this.

Signed-off-by: Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>
---
 tools/libxl/xl.c |    3 ---
 1 files changed, 3 deletions(-)

diff -r 5a5c2ed76aaf -r 5254234fdb71 tools/libxl/xl.c
--- a/tools/libxl/xl.c  Fri Jan 08 11:44:15 2010 +0000
+++ b/tools/libxl/xl.c  Fri Jan 08 11:44:58 2010 +0000
@@ -888,9 +888,6 @@ start:
     }
 
     close(logfile);
-    for (i = 0; i < num_vifs; i++) {
-        free(vifs[i].ifname);
-    }
     free(disks);
     free(vifs);
     free(vfbs);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] libxenlight: don't free ifname, can lead to double free, Xen patchbot-unstable <=