WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] tmem: fix regression from c/s 19886 "Remo

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] tmem: fix regression from c/s 19886 "Remove page-scrub lists and async scrubbing"
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 22 Nov 2009 23:35:22 -0800
Delivery-date: Sun, 22 Nov 2009 23:35:49 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1258958703 0
# Node ID 8f200fe950afea593792df3eedcded98fe803a72
# Parent  1bbc132675a29a030ba7b1ab4b5f6ade8087f94c
tmem: fix regression from c/s 19886 "Remove page-scrub lists and async 
scrubbing"

Fix incorrect page_list macro choice from page-scrub code cleanup.

Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
---
 xen/common/tmem_xen.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff -r 1bbc132675a2 -r 8f200fe950af xen/common/tmem_xen.c
--- a/xen/common/tmem_xen.c     Mon Nov 23 06:43:50 2009 +0000
+++ b/xen/common/tmem_xen.c     Mon Nov 23 06:45:03 2009 +0000
@@ -213,12 +213,13 @@ EXPORT void tmh_release_avail_pages_to_h
     spin_lock(&tmh_page_list_lock);
     while ( !page_list_empty(&tmh_page_list) )
     {
-        struct page_info *pg = page_list_first(&tmh_page_list);
+        struct page_info *pg = page_list_remove_head(&tmh_page_list);
         scrub_one_page(pg);
+        tmh_page_list_pages--;
         free_domheap_page(pg);
     }
+    ASSERT(tmh_page_list_pages == 0);
     INIT_PAGE_LIST_HEAD(&tmh_page_list);
-    tmh_page_list_pages = 0;
     spin_unlock(&tmh_page_list_lock);
 }
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] tmem: fix regression from c/s 19886 "Remove page-scrub lists and async scrubbing", Xen patchbot-unstable <=