xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] xenpmd: Adjust strncat() length to avoid

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] xenpmd: Adjust strncat() length to avoid static buffer overflow.
From:	Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Sat, 06 Dec 2008 04:20:10 -0800
Delivery-date:	Sat, 06 Dec 2008 04:20:24 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1228256242 0
# Node ID 2797ad5509252b49820fc1713209dc4cf95a9962
# Parent  fc5208167bb69f7d02247644fd76a82a2649e310
xenpmd: Adjust strncat() length to avoid static buffer overflow.
Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 tools/xenpmd/xenpmd.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r fc5208167bb6 -r 2797ad550925 tools/xenpmd/xenpmd.c
--- a/tools/xenpmd/xenpmd.c     Tue Dec 02 11:53:24 2008 +0000
+++ b/tools/xenpmd/xenpmd.c     Tue Dec 02 22:17:22 2008 +0000
@@ -373,7 +373,7 @@ void write_battery_info_to_xenstore(stru
              (unsigned int)strlen(info->serial_number), info->serial_number,
              (unsigned int)strlen(info->battery_type), info->battery_type,
              (unsigned int)strlen(info->oem_info), info->oem_info);
-    strncat(val+73, string_info, 1024);
+    strncat(val+73, string_info, 1024-73-1);
     xs_write(xs, XBT_NULL, "/pm/bif", 
              val, 73+8+strlen(info->model_number)+strlen(info->serial_number)+
              strlen(info->battery_type)+strlen(info->oem_info)+1);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] xenpmd: Adjust strncat() length to avoid static buffer overflow., Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] Fix Xen panic with oprofile, Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] x86: No need for short jmp before long hjmp when setting CR0.PE, Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] Fix Xen panic with oprofile, Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] x86: No need for short jmp before long hjmp when setting CR0.PE, Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]