WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [linux-2.6.18-xen] Don't WARN_ON -ENOSYS from PHYSDEVOP_

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [linux-2.6.18-xen] Don't WARN_ON -ENOSYS from PHYSDEVOP_manage_pci_remove
From: "Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 08 Aug 2008 07:30:30 -0700
Delivery-date: Fri, 08 Aug 2008 07:31:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1218189299 -3600
# Node ID 87413eba04ab80ef1d87bff6ff92ebe2f64214d8
# Parent  2866e6af503ea0b33e1c1fb2340ab8ed81925e97
Don't WARN_ON -ENOSYS from PHYSDEVOP_manage_pci_remove

We let -ENOSYS slip through on the add side to support old
hypervisors, let's do the same on the remove end so we don't get stack
dumps during bootup.

Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
---
 drivers/xen/core/pci.c |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff -r 2866e6af503e -r 87413eba04ab drivers/xen/core/pci.c
--- a/drivers/xen/core/pci.c    Thu Jul 31 15:33:54 2008 +0100
+++ b/drivers/xen/core/pci.c    Fri Aug 08 10:54:59 2008 +0100
@@ -23,9 +23,13 @@ static int pci_bus_probe_wrapper(struct 
                return r;
 
        r = pci_bus_probe(dev);
-       if (r)
-               WARN_ON(HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
-                                             &manage_pci));
+       if (r) {
+               int ret;
+
+               ret = HYPERVISOR_physdev_op(PHYSDEVOP_manage_pci_remove,
+                                           &manage_pci);
+               WARN_ON(ret && ret != -ENOSYS);
+       }
 
        return r;
 }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [linux-2.6.18-xen] Don't WARN_ON -ENOSYS from PHYSDEVOP_manage_pci_remove, Xen patchbot-linux-2.6.18-xen <=