# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1204206268 0
# Node ID 5f7bfdeb87487fefcfa24c5e650fcf61a570aa99
# Parent 15c3c136206d89c4f33ba09d956d798d6fa17126
NUMA node migration
Adds NUMA node migration based on live migration to
xend. By adding another parameter to "xm migrate" the target NUMA node
number gets propagated to the target host (can be both localhost or a
remote host). The restore function then sets the VCPU affinity
accordingly. Only changes Python code in xend. I hope that the patch
doesn't break XenAPI compatibility (adding a parameter seems fine?).
# xm migrate --live --node=<nodenr> <domid> localhost
<nodenr> is the number as shown with 'xm info' under node_to_cpu
I am aware that using live migration isn't the best approach (takes
twice the memory and quite some time), but it's less intrusive and
works fine (given localhost migration stability...)
Signed-off-by: Andre Przywara <andre.przywara@xxxxxxx>
---
tools/python/xen/xend/XendAPI.py | 3 +-
tools/python/xen/xend/XendCheckpoint.py | 33 ++++++++++++++++++++++++++++++--
tools/python/xen/xend/XendDomain.py | 6 +++--
tools/python/xen/xm/migrate.py | 10 +++++++--
4 files changed, 45 insertions(+), 7 deletions(-)
diff -r 15c3c136206d -r 5f7bfdeb8748 tools/python/xen/xend/XendAPI.py
--- a/tools/python/xen/xend/XendAPI.py Thu Feb 28 13:40:30 2008 +0000
+++ b/tools/python/xen/xend/XendAPI.py Thu Feb 28 13:44:28 2008 +0000
@@ -1761,9 +1761,10 @@ class XendAPI(object):
resource = other_config.get("resource", 0)
port = other_config.get("port", 0)
+ node = other_config.get("node", 0)
xendom.domain_migrate(xeninfo.getDomid(), destination_url,
- bool(live), resource, port)
+ bool(live), resource, port, node)
return xen_api_success_void()
def VM_save(self, _, vm_ref, dest, checkpoint):
diff -r 15c3c136206d -r 5f7bfdeb8748 tools/python/xen/xend/XendCheckpoint.py
--- a/tools/python/xen/xend/XendCheckpoint.py Thu Feb 28 13:40:30 2008 +0000
+++ b/tools/python/xen/xend/XendCheckpoint.py Thu Feb 28 13:44:28 2008 +0000
@@ -22,6 +22,7 @@ from xen.xend.XendLogging import log
from xen.xend.XendLogging import log
from xen.xend.XendConfig import XendConfig
from xen.xend.XendConstants import *
+from xen.xend import XendNode
SIGNATURE = "LinuxGuestRecord"
QEMU_SIGNATURE = "QemuDeviceModelRecord"
@@ -56,10 +57,23 @@ def read_exact(fd, size, errmsg):
return buf
-def save(fd, dominfo, network, live, dst, checkpoint=False):
+def insert_after(list, pred, value):
+ for i,k in enumerate(list):
+ if type(k) == type([]):
+ if k[0] == pred:
+ list.insert (i+1, value)
+ return
+
+
+def save(fd, dominfo, network, live, dst, checkpoint=False, node=-1):
write_exact(fd, SIGNATURE, "could not write guest state file: signature")
- config = sxp.to_string(dominfo.sxpr())
+ sxprep = dominfo.sxpr()
+
+ if node > -1:
+ insert_after(sxprep,'vcpus',['node', str(node)])
+
+ config = sxp.to_string(sxprep)
domain_name = dominfo.getName()
# Rename the domain temporarily, so that we don't get a name clash if this
@@ -191,6 +205,21 @@ def restore(xd, fd, dominfo = None, paus
dominfo.resume()
else:
dominfo = xd.restore_(vmconfig)
+
+ # repin domain vcpus if a target node number was specified
+ # this is done prior to memory allocation to aide in memory
+ # distribution for NUMA systems.
+ nodenr = -1
+ for i,l in enumerate(vmconfig):
+ if type(l) == type([]):
+ if l[0] == 'node':
+ nodenr = int(l[1])
+
+ if nodenr >= 0:
+ node_to_cpu = XendNode.instance().xc.physinfo()['node_to_cpu']
+ if nodenr < len(node_to_cpu):
+ for v in range(0, dominfo.info['VCPUs_max']):
+ xc.vcpu_setaffinity(dominfo.domid, v, node_to_cpu[nodenr])
store_port = dominfo.getStorePort()
console_port = dominfo.getConsolePort()
diff -r 15c3c136206d -r 5f7bfdeb8748 tools/python/xen/xend/XendDomain.py
--- a/tools/python/xen/xend/XendDomain.py Thu Feb 28 13:40:30 2008 +0000
+++ b/tools/python/xen/xend/XendDomain.py Thu Feb 28 13:44:28 2008 +0000
@@ -1258,7 +1258,7 @@ class XendDomain:
return val
- def domain_migrate(self, domid, dst, live=False, resource=0, port=0):
+ def domain_migrate(self, domid, dst, live=False, resource=0, port=0,
node=-1):
"""Start domain migration.
@param domid: Domain ID or Name
@@ -1271,6 +1271,8 @@ class XendDomain:
@type live: bool
@keyword resource: not used??
@rtype: None
+ @keyword node: use node number for target
+ @rtype: int
@raise XendError: Failed to migrate
@raise XendInvalidDomain: Domain is not valid
"""
@@ -1299,7 +1301,7 @@ class XendDomain:
sock.send("receive\n")
sock.recv(80)
- XendCheckpoint.save(sock.fileno(), dominfo, True, live, dst)
+ XendCheckpoint.save(sock.fileno(), dominfo, True, live, dst, node=node)
sock.close()
def domain_save(self, domid, dst, checkpoint=False):
diff -r 15c3c136206d -r 5f7bfdeb8748 tools/python/xen/xm/migrate.py
--- a/tools/python/xen/xm/migrate.py Thu Feb 28 13:40:30 2008 +0000
+++ b/tools/python/xen/xm/migrate.py Thu Feb 28 13:44:28 2008 +0000
@@ -43,6 +43,10 @@ gopts.opt('port', short='p', val='portnu
fn=set_int, default=0,
use="Use specified port for migration.")
+gopts.opt('node', short='n', val='nodenum',
+ fn=set_int, default=-1,
+ use="Use specified NUMA node on target.")
+
gopts.opt('resource', short='r', val='MBIT',
fn=set_int, default=0,
use="Set level of resource usage for migration.")
@@ -65,11 +69,13 @@ def main(argv):
vm_ref = get_single_vm(dom)
other_config = {
"port": opts.vals.port,
- "resource": opts.vals.resource
+ "resource": opts.vals.resource,
+ "node": opts.vals.node
}
server.xenapi.VM.migrate(vm_ref, dst, bool(opts.vals.live),
other_config)
else:
server.xend.domain.migrate(dom, dst, opts.vals.live,
opts.vals.resource,
- opts.vals.port)
+ opts.vals.port,
+ opts.vals.node)
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog
|
Home