xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] x86: Fix HVM hypercall preemption causing

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] x86: Fix HVM hypercall preemption causing guest crash.
From:	Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Tue, 29 Jan 2008 07:40:12 -0800
Delivery-date:	Tue, 29 Jan 2008 07:40:23 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1201607262 0
# Node ID 128f7bc0a277375571b4817fc65bfcd14e00a7ec
# Parent  7aa2149a3b0e94eb01b39ae8cf4a41bc225be94e
x86: Fix HVM hypercall preemption causing guest crash.
Signed-off-by: Yu Zhao <yu.zhao@xxxxxxxxx>
---
 xen/arch/x86/domain.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)

diff -r 7aa2149a3b0e -r 128f7bc0a277 xen/arch/x86/domain.c
--- a/xen/arch/x86/domain.c     Tue Jan 29 11:45:15 2008 +0000
+++ b/xen/arch/x86/domain.c     Tue Jan 29 11:47:42 2008 +0000
@@ -1506,7 +1506,12 @@ unsigned long hypercall_create_continuat
     {
         regs       = guest_cpu_user_regs();
         regs->eax  = op;
-        regs->eip -= 2;  /* re-execute 'syscall' / 'int 0x82' */
+        /*
+         * For PV guest, we update EIP to re-execute 'syscall' / 'int 0x82';
+         * HVM does not need this since 'vmcall' / 'vmmcall' is fault-like.
+         */
+        if ( !is_hvm_vcpu(current) )
+            regs->eip -= 2;  /* re-execute 'syscall' / 'int 0x82' */
 
 #ifdef __x86_64__
         if ( !is_hvm_vcpu(current) ?

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] x86: Fix HVM hypercall preemption causing guest crash., Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] ioemu: Add support for e100 nic save/restore., Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] x86: Fix shadow pinning logic (for PV live relo)., Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] ioemu: Add support for e100 nic save/restore., Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] x86: Fix shadow pinning logic (for PV live relo)., Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]