WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] xenstore: expanding_buffer variables are

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] xenstore: expanding_buffer variables are supposed to be static. Apart
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 05 Dec 2007 16:20:22 -0800
Delivery-date: Wed, 05 Dec 2007 16:21:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1196877373 0
# Node ID 8ba08f2244b29ec2a1436467b4d5dc30e770accb
# Parent  46af6ec3ae4e308387fdcccfeb9300374255e4fc
xenstore: expanding_buffer variables are supposed to be static. Apart
from anything else, this was guaranteeing they were initialised.
Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 tools/xenstore/xenstore_client.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -r 46af6ec3ae4e -r 8ba08f2244b2 tools/xenstore/xenstore_client.c
--- a/tools/xenstore/xenstore_client.c  Wed Dec 05 17:28:59 2007 +0000
+++ b/tools/xenstore/xenstore_client.c  Wed Dec 05 17:56:13 2007 +0000
@@ -138,7 +138,7 @@ perform(int optind, int argc, char **arg
 {
     while (optind < argc) {
 #if defined(CLIENT_read)
-       struct expanding_buffer ebuf;
+       static struct expanding_buffer ebuf;
        unsigned len;
        char *val = xs_read(xsh, xth, argv[optind], &len);
        if (val == NULL) {
@@ -151,7 +151,7 @@ perform(int optind, int argc, char **arg
        free(val);
        optind++;
 #elif defined(CLIENT_write)
-       struct expanding_buffer ebuf;
+       static struct expanding_buffer ebuf;
        char *val_spec = argv[optind + 1];
        unsigned len;
        expanding_buffer_ensure(&ebuf, strlen(val_spec)+1);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] xenstore: expanding_buffer variables are supposed to be static. Apart, Xen patchbot-unstable <=