WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] x86: Do not #GP when guest writes unexpec

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: Do not #GP when guest writes unexpected values to CR4. Just
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 07 Sep 2007 09:13:18 -0700
Delivery-date: Fri, 07 Sep 2007 09:27:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1188395654 -3600
# Node ID 747b71c8c4a8d0a7e72c2bbadba23d974ba5d10b
# Parent  79053138b35c8e77ef828f920ce0c68543c6a932
x86: Do not #GP when guest writes unexpected values to CR4. Just
ignore them.
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
---
 xen/arch/x86/traps.c |    9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diff -r 79053138b35c -r 747b71c8c4a8 xen/arch/x86/traps.c
--- a/xen/arch/x86/traps.c      Wed Aug 29 14:40:00 2007 +0100
+++ b/xen/arch/x86/traps.c      Wed Aug 29 14:54:14 2007 +0100
@@ -1673,12 +1673,11 @@ static int emulate_privileged_op(struct 
                 goto fail;
             break;
 
-        case 4:
+        case 4: /* Write CR4 */
             if ( *reg != (read_cr4() & ~(X86_CR4_PGE|X86_CR4_PSE)) )
-            {
-                gdprintk(XENLOG_WARNING, "Attempt to change CR4 flags.\n");
-                goto fail;
-            }
+                gdprintk(XENLOG_WARNING,
+                         "Attempt to change CR4 flags %08lx -> %08lx\n",
+                         read_cr4() & ~(X86_CR4_PGE|X86_CR4_PSE), *reg);
             break;
 
         default:

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: Do not #GP when guest writes unexpected values to CR4. Just, Xen patchbot-unstable <=