 Home |
Products |
Support |
Community |
News |
xen-changelog
Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 han
| To: | "Petersson, Mats" <Mats.Petersson@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, <xen-changelog@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handling with VMX. |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Thu, 28 Jun 2007 13:57:28 +0100 |
| Delivery-date: | Thu, 28 Jun 2007 05:55:38 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <907625E08839C4409CE5768403633E0B02561EB1@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Ace5H9GWe9vOGd6URTGl9AY7I2RrHwAS0YNQAAYyfRY= |
| Thread-topic: | [Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handling with VMX. |
| User-agent: | Microsoft-Entourage/11.3.3.061214 |
On 28/6/07 11:33, "Petersson, Mats" <Mats.Petersson@xxxxxxx> wrote: >> -/* These bits in the CR4 are owned by the host */ >> +/* These bits in CR4 are owned by the host. */ >> #define HVM_CR4_HOST_MASK (mmu_cr4_features & \ >> (X86_CR4_VMXE | X86_CR4_PAE | X86_CR4_MCE)) > > VMXE is only for Intel, so being very picky, it shouldn't be in a HVM > environment. > > I don't think it's a problem as, I doubt very much that AMD would use > this bit for anything in the future, as Intel has "occupied it", and > we're using a different way to enable SVM. The code is entirely benign on AMD until that happens *and* we actually make use of it by adding it to mmu_cr4_features. So this is the way of simplest code for now. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handling with VMX., Petersson, Mats |
|---|---|
| Next by Date: | [Xen-changelog] [xen-unstable] Fix fixup of invalid PTE writes, broken by 13392:0fd65225e4c6., Xen patchbot-unstable |
| Previous by Thread: | [Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handling with VMX., Petersson, Mats |
| Next by Thread: | [Xen-changelog] [xen-unstable] vmx: Make use of VMX_INSTRUCTION_INFO field to obtain the segment, Xen patchbot-unstable |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
