xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] [XEND] Improve error message for unparsed

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] [XEND] Improve error message for unparsed disk modes.
From:	Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Wed, 01 Nov 2006 11:40:13 +0000
Delivery-date:	Thu, 02 Nov 2006 13:47:18 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Node ID 90164f5fbd5006a9c3dbc33c3795dbe24be20da2
# Parent  2db4388fecb9d08fa2a435d2bfcc3026fb14f218
[XEND] Improve error message for unparsed disk modes.
Signed-off-by: John Levon <john.levon@xxxxxxx>
---
 tools/python/xen/xend/server/blkif.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletion(-)

diff -r 2db4388fecb9 -r 90164f5fbd50 tools/python/xen/xend/server/blkif.py
--- a/tools/python/xen/xend/server/blkif.py     Tue Oct 31 16:42:46 2006 +0000
+++ b/tools/python/xen/xend/server/blkif.py     Tue Oct 31 18:24:44 2006 +0000
@@ -66,7 +66,11 @@ class BlkifController(DevController):
 
         mode = sxp.child_value(config, 'mode', 'r')
         if mode not in ('r', 'w', 'w!'):
-            raise VmError('Invalid mode')
+            name = uname
+            if not name:
+                name = sxp.child_value(config, 'dev')
+            raise VmError('Invalid mode \'%s\' for %s. Valid modes are '
+            '{r,w,w!}' % (mode, name))
 
         back = { 'dev'    : dev,
                  'type'   : typ,

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] [XEND] Improve error message for unparsed disk modes., Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] [PV-ON-HVM] Don't generate lots of spurious interrupts when using event, Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] [XEN] Cleanup and optimize layout of credit scheduler stats., Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] [PV-ON-HVM] Don't generate lots of spurious interrupts when using event, Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] [XEN] Cleanup and optimize layout of credit scheduler stats., Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]