xen-changelog

[Top] [All Lists]

[Xen-changelog] Avoid spurious timer activations in migrate_timer().

from [Xen patchbot -unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] Avoid spurious timer activations in migrate_timer().
From:	Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Sat, 22 Apr 2006 13:10:09 +0000
Delivery-date:	Sat, 22 Apr 2006 06:12:15 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID b2323eefb79e75bdf0b24ac02093bdd70e1f44f5
# Parent  3145b215598c87c35040f9c79f3a3ff1b4d6130a
Avoid spurious timer activations in migrate_timer().

Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

diff -r 3145b215598c -r b2323eefb79e xen/common/timer.c
--- a/xen/common/timer.c        Sat Apr 22 10:26:28 2006 +0100
+++ b/xen/common/timer.c        Sat Apr 22 10:37:24 2006 +0100
@@ -251,12 +251,15 @@ void migrate_timer(struct timer *timer, 
     }
 
     if ( active_timer(timer) )
-        __stop_timer(timer);
-
-    timer->cpu = new_cpu;
-
-    if ( likely(!timer->killed) )
+    {
+        __stop_timer(timer);
+        timer->cpu = new_cpu;
         __add_timer(timer);
+    }
+    else
+    {
+        timer->cpu = new_cpu;
+    }
 
     spin_unlock(&timers[old_cpu].lock);
     spin_unlock_irqrestore(&timers[new_cpu].lock, flags);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] Avoid spurious timer activations in migrate_timer()., Xen patchbot -unstable <= [Xen-changelog] Avoid spurious timer activations in migrate_timer()., Xen patchbot -3 . 0-testing

Previous by Date:	[Xen-changelog] Remove update_vcpu_system_time() call from the per-VCPU timer, Xen patchbot -unstable
Next by Date:	[Xen-changelog] The Xen checksum offload feature attempts to insert a TCP/UDP, Xen patchbot -unstable
Previous by Thread:	[Xen-changelog] Remove update_vcpu_system_time() call from the per-VCPU timer, Xen patchbot -unstable
Next by Thread:	[Xen-changelog] Avoid spurious timer activations in migrate_timer()., Xen patchbot -3 . 0-testing
Indexes:	[Date] [Thread] [Top] [All Lists]