[Xen-changelog] Currently, it is possible to set the mem-max value to value lower than

[Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 5102cd121a360fd38e9792356a62f187599ef9ba
# Parent  1fe63743a147f0305415e4bb8629f1e78ed3e754
Currently, it is possible to set the mem-max value to value lower than
what has been currently allocated to the domain causing the kernel to
crash. This patch validates the value passed in and prevents setting the
value below the current allocation level.

Signed-off-by: ksrinivasan@xxxxxxxxxx

diff -r 1fe63743a147 -r 5102cd121a36 xen/common/dom0_ops.c
--- a/xen/common/dom0_ops.c     Fri Apr 14 20:22:09 2006
+++ b/xen/common/dom0_ops.c     Sat Apr 15 08:47:55 2006
@@ -585,9 +585,16 @@
         d = find_domain_by_id(op->u.setdomainmaxmem.domain);
         if ( d != NULL )
         {
-            d->max_pages = op->u.setdomainmaxmem.max_memkb >> (PAGE_SHIFT-10);
-            put_domain(d);
-            ret = 0;
+            unsigned long new_max;
+            new_max = op->u.setdomainmaxmem.max_memkb >> (PAGE_SHIFT-10);
+            if (new_max < d->tot_pages) 
+                ret = -EINVAL;
+            else 
+            {  
+                d->max_pages = new_max;
+                ret = 0;
+            }
+            put_domain(d);
         }
     }
     break;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog