xen-changelog

[Top] [All Lists]

[Xen-changelog] Since we don't reset the proto_csum_blank flag in the sk

from [Xen patchbot -3 . 0-testing]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] Since we don't reset the proto_csum_blank flag in the skb, the
From:	Xen patchbot -3.0-testing <patchbot-3.0-testing@xxxxxxxxxxxxxxxxxxx>
Date:	Fri, 14 Apr 2006 15:30:16 +0000
Delivery-date:	Fri, 14 Apr 2006 08:31:11 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID dfc89d085f6fcb7699a48f12ce553e458af16e43
# Parent  86af7d0a244d7e0c2101f286075ae078b47d67ca
Since we don't reset the proto_csum_blank flag in the skb, the
checksum calculation gets done twice, which is not twice as good as
once.

With this patch, TCP/UDP checksum errors from dom0 are fixed, and
domUs can use TCP/UDP without turning off TX checksum offload.  Normal
non-VLAN bridged configs still work fine, tested with xm-test.

Signed-off-by: Jim Dykman <dykman@xxxxxxxxxx>

diff -r 86af7d0a244d -r dfc89d085f6f linux-2.6-xen-sparse/net/core/dev.c
--- a/linux-2.6-xen-sparse/net/core/dev.c       Fri Apr 14 13:19:05 2006
+++ b/linux-2.6-xen-sparse/net/core/dev.c       Fri Apr 14 13:24:38 2006
@@ -1294,6 +1294,7 @@
                if ((skb->h.raw + skb->csum + 2) > skb->tail)
                        goto out_kfree_skb;
                skb->ip_summed = CHECKSUM_HW;
+               skb->proto_csum_blank = 0;
        }
 #endif
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] Since we don't reset the proto_csum_blank flag in the skb, the, Xen patchbot -3 . 0-testing <= [Xen-changelog] Since we don't reset the proto_csum_blank flag in the skb, the, Xen patchbot -unstable

Previous by Date:	[Xen-changelog] Trivial patch to fix x86_64 builds in which XEN_TARGET_ARCH, Xen patchbot -3 . 0-testing
Next by Date:	[Xen-changelog] Must use __copy_to_user_inatomic() in swiotlb's sync_single(), Xen patchbot -unstable
Previous by Thread:	[Xen-changelog] Trivial patch to fix x86_64 builds in which XEN_TARGET_ARCH, Xen patchbot -3 . 0-testing
Next by Thread:	[Xen-changelog] Since we don't reset the proto_csum_blank flag in the skb, the, Xen patchbot -unstable
Indexes:	[Date] [Thread] [Top] [All Lists]