xen-changelog

[Top] [All Lists]

[Xen-changelog] Do not BUG when receiving unexpected message type from x

from [Xen patchbot -unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] Do not BUG when receiving unexpected message type from xenbus
From:	Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Wed, 15 Mar 2006 18:50:09 +0000
Delivery-date:	Wed, 15 Mar 2006 18:51:38 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User vhanquez@xxxxxxxxxxxxxxxxxxxxxxx
# Node ID 890fa761ba82a26988b1a5cb5ec0359706f75df8
# Parent  f00e257d200c0178e15eb32a0cb1fbf66e739971
Do not BUG when receiving unexpected message type from xenbus
print a warning and discard the query

Signed-off-by: Vincent Hanquez <vincent@xxxxxxxxxxxxx>

diff -r f00e257d200c -r 890fa761ba82 
linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_xs.c
--- a/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_xs.c       Wed Mar 15 
10:33:43 2006
+++ b/linux-2.6-xen-sparse/drivers/xen/xenbus/xenbus_xs.c       Wed Mar 15 
11:09:45 2006
@@ -237,7 +237,14 @@
                return ERR_PTR(-err);
        }
 
-       BUG_ON(msg.type != type);
+       if (msg.type != type) {
+               if (printk_ratelimit())
+                       printk(KERN_WARNING
+                              "XENBUS unexpected type [%d], expected [%d]\n",
+                              msg.type, type);
+               kfree(ret);
+               return ERR_PTR(-EINVAL);
+       }
        return ret;
 }
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] Do not BUG when receiving unexpected message type from xenbus, Xen patchbot -unstable <=

Previous by Date:	[Xen-changelog] There is no need to pin page tables when XENFEAT_writable_page_tables, Xen patchbot -unstable
Next by Date:	[Xen-changelog] Fix 64-bit build., Xen patchbot -unstable
Previous by Thread:	[Xen-changelog] There is no need to pin page tables when XENFEAT_writable_page_tables, Xen patchbot -unstable
Next by Thread:	[Xen-changelog] Fix 64-bit build., Xen patchbot -unstable
Indexes:	[Date] [Thread] [Top] [All Lists]