[Xen-changelog] Arch-specific per-vcpu info should be initialised to zero

[Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 85d693e6f61aacc709d7a0adceb0090543e762e3
# Parent  d8415ebc8c87e50f5716ffe157c821b539897548
Arch-specific per-vcpu info should be initialised to zero
when allocating a new vcpu structure, not copied from
CPU0's idle VCPU. Especially now that the idle VCPU itself
is dynamically allocated. 

This should fix assertions people have been seeing in
getdomain_info_ctxt() relation to IOPL in eflags.

Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>

diff -r d8415ebc8c87 -r 85d693e6f61a xen/arch/x86/domain.c
--- a/xen/arch/x86/domain.c     Sat Jan 14 16:05:31 2006
+++ b/xen/arch/x86/domain.c     Sat Jan 14 20:26:40 2006
@@ -215,14 +215,10 @@
 
     memset(v, 0, sizeof(*v));
 
-    memcpy(&v->arch, &idle_vcpu[0]->arch, sizeof(v->arch));
     v->arch.flags = TF_kernel_mode;
 
     if ( is_idle_domain(d) )
-    {
         percpu_ctxt[vcpu_id].curr_vcpu = v;
-        v->arch.schedule_tail = continue_idle_domain;
-    }
 
     if ( (v->vcpu_id = vcpu_id) != 0 )
     {
@@ -333,9 +329,10 @@
         memset(d->shared_info, 0, PAGE_SIZE);
         v->vcpu_info = &d->shared_info->vcpu_info[v->vcpu_id];
         SHARE_PFN_WITH_DOMAIN(virt_to_page(d->shared_info), d);
-
-        v->arch.schedule_tail = continue_nonidle_domain;
-    }
+    }
+
+    v->arch.schedule_tail = is_idle_domain(d) ?
+        continue_idle_domain : continue_nonidle_domain;
 
     return 0;
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog