WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] Fix block_attach_shared tests. When the sharing check su

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] Fix block_attach_shared tests. When the sharing check succeeds, the domain
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 15 Dec 2005 19:50:07 +0000
Delivery-date: Thu, 15 Dec 2005 19:52:09 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User emellor@xxxxxxxxxxxxxxxxxxxxxx
# Node ID d8c7f144ca5425f493447a8bdfab668c64feb5e9
# Parent  c28794c159c1704bfe4780e8a4f0b6c0e16a70a8
Fix block_attach_shared tests.  When the sharing check succeeds, the domain
is created but left paused, so it is necessary to destroy the domain afterwards,
whether the test succeeded or failed.

Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx>

diff -r c28794c159c1 -r d8c7f144ca54 
tools/xm-test/tests/block-create/11_block_attach_shared_dom0.py
--- a/tools/xm-test/tests/block-create/11_block_attach_shared_dom0.py   Thu Dec 
15 13:39:16 2005
+++ b/tools/xm-test/tests/block-create/11_block_attach_shared_dom0.py   Thu Dec 
15 13:49:07 2005
@@ -34,3 +34,5 @@
     FAIL("Bug #331: Started a DomU with write access to a rw mounted block 
device")
 except DomainError, e:
     s, o = traceCommand("umount mnt")
+
+domain.destroy()
diff -r c28794c159c1 -r d8c7f144ca54 
tools/xm-test/tests/block-create/12_block_attach_shared_domU.py
--- a/tools/xm-test/tests/block-create/12_block_attach_shared_domU.py   Thu Dec 
15 13:39:16 2005
+++ b/tools/xm-test/tests/block-create/12_block_attach_shared_domU.py   Thu Dec 
15 13:49:07 2005
@@ -20,8 +20,11 @@
     FAIL("Unable to start domain")
 
 try:
-    dom2.start()
+    try:
+        dom2.start()
+        FAIL("Bug #331: Started a DomU with write access to an in-use block 
device")
+    except DomainError, e:
+        pass
+finally:
     dom1.destroy()
-    FAIL("Bug #331: Started a DomU with write access to an in-use block 
device")
-except DomainError, e:
-    dom1.destroy()
+    dom2.destroy()

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] Fix block_attach_shared tests. When the sharing check succeeds, the domain, Xen patchbot -unstable <=