[Xen-changelog] Don't refuse to clean up after a domain death when the buffer is not empty. If

[Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User emellor@xxxxxxxxxxxxxxxxxxxxxx
# Node ID 69df979de1a7c055fb62564101b853e5456fa3b5
# Parent  e33f8d664e2d3575a6160b06ec3e67b2d2c8dca6
Don't refuse to clean up after a domain death when the buffer is not empty.  If
the domain has gone away, then no-one can attach to the pty because Xend will
have cleaned up the entries in the store, so the pty will never become ready to
write.  The buffer will never get emptied, so cleanup will never occur. This
leaks ptys, file descriptors, and memory.  Simply throw those data away instead.

Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx>

diff -r e33f8d664e2d -r 69df979de1a7 tools/console/daemon/io.c
--- a/tools/console/daemon/io.c Wed Nov 30 18:43:00 2005
+++ b/tools/console/daemon/io.c Wed Nov 30 18:48:27 2005
@@ -376,9 +376,6 @@
 
 static void cleanup_domain(struct domain *d)
 {
-       if (!buffer_empty(&d->buffer))
-               return;
-
        if (d->tty_fd != -1) {
                close(d->tty_fd);
                d->tty_fd = -1;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog