WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] Don't treat the failure of ifconfig vifX.Y down as a fat

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] Don't treat the failure of ifconfig vifX.Y down as a fatal error. This hasn't
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 23 Nov 2005 21:00:08 +0000
Delivery-date: Wed, 23 Nov 2005 21:00:35 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User emellor@xxxxxxxxxxxxxxxxxxxxxx
# Node ID 8aabf8959595e676f05f08ab17e25575982b1438
# Parent  e48bb8550f95c151dcda95a043af88e12fc899d9
Don't treat the failure of ifconfig vifX.Y down as a fatal error.  This hasn't
emerged as a problem in the field, AFAIK, but it seems that distro scripts
could have brought the device down already by this point (Debian stable's
net.agent does ifdown vifX.Y, and it wouldn't surprise me if someone decided
to do ifconfig vifX.Y down if this failed, for example).

Logging but ignoring the failure seems sensible.

Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx>

diff -r e48bb8550f95 -r 8aabf8959595 tools/examples/vif-bridge
--- a/tools/examples/vif-bridge Wed Nov 23 19:13:13 2005
+++ b/tools/examples/vif-bridge Wed Nov 23 19:16:54 2005
@@ -62,7 +62,7 @@
 
     offline)
         # vifs are auto-removed from bridge.
-        ifconfig "$vif" down || fatal "ifconfig $vif down failed"
+        ifconfig "$vif" down || log err "ifconfig $vif down failed"
         ;;
 esac
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] Don't treat the failure of ifconfig vifX.Y down as a fatal error. This hasn't, Xen patchbot -unstable <=