WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-devel] Re: [Xen-changelog] Fix Xen to build with gcc-4.1.

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] Fix Xen to build with gcc-4.1.
From: Jerone Young <jyoung5@xxxxxxxxxx>
Date: Wed, 23 Nov 2005 11:26:00 -0600
Cc: xen-changelog@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 23 Nov 2005 17:26:22 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E1EewLy-0000On-Tb@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E1EewLy-0000On-Tb@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2005-11-23 at 15:16 +0000, Xen patchbot -unstable wrote:
> # HG changeset patch
> # User kaf24@xxxxxxxxxxxxxxxxxxxx
> # Node ID 14d733e5e1d014e302d72fb78df1428ee08e3ce3
> # Parent  6cc603ac3f38f8f4b760899e963ef8165ae0c8ee
> Fix Xen to build with gcc-4.1.
> 
> Signed-off-by: Vincent Hanquez <vincent@xxxxxxxxxxxxx>
> 
> diff -r 6cc603ac3f38 -r 14d733e5e1d0 xen/include/asm-x86/apic.h
> --- a/xen/include/asm-x86/apic.h      Wed Nov 23 13:14:01 2005
> +++ b/xen/include/asm-x86/apic.h      Wed Nov 23 13:15:35 2005
> @@ -43,7 +43,7 @@
>  
>  static __inline void apic_write_atomic(unsigned long reg, u32 v)
>  {
> -     xchg((volatile u32 *)(APIC_BASE+reg), v);
> +     (void)xchg((volatile u32 *)(APIC_BASE+reg), v);
>  }

Is it just me or are the gcc folks taking this stuff a little too far
since gcc 4. Having to cast to void in an inline function just seems a
bit overboard.


>  
>  static __inline u32 apic_read(unsigned long reg)
> 
> _______________________________________________
> Xen-changelog mailing list
> Xen-changelog@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-changelog
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>