WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] Avoid GPF when attempting to save / restore 64bit guests

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] Avoid GPF when attempting to save / restore 64bit guests. More thought
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 22 Nov 2005 19:54:08 +0000
Delivery-date: Tue, 22 Nov 2005 19:54:29 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User smh22@xxxxxxxxxxxxxxxxxxxx
# Node ID 393256b2ead0c883e2095479e1c66d2e34d18a10
# Parent  c7508abc5b6b1aac2f8ee63fe56922f43c457cc3
Avoid GPF when attempting to save / restore 64bit guests. More thought 
required as to best way to get M2P mfns under 64...

Signed-off-by: Steven Hand <steven@xxxxxxxxxxxxx>

diff -r c7508abc5b6b -r 393256b2ead0 
linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c
--- a/linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c        Tue Nov 22 
17:44:08 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c        Tue Nov 22 
18:10:50 2005
@@ -222,6 +222,17 @@
                unsigned long *p; 
                int i; 
 
+#if defined (__x86_64__)
+               /* 
+               ** XXX SMH: the below procedure won't work for 64 since 
+               ** we don't have access to the memory which maps the M2P. 
+               ** A proper fix will probably involve moving this 
+               ** functionality to Xen - for now just return an error 
+               ** here rather than GPF'ing in the kernel. 
+               */
+               ret = -EINVAL; 
+               break; 
+#endif
                if (copy_from_user(&m, (void *)data, sizeof(m)))
                        return -EFAULT;
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] Avoid GPF when attempting to save / restore 64bit guests. More thought, Xen patchbot -unstable <=