xen-changelog

[Top] [All Lists]

[Xen-changelog] Don't leak memory when realloc fails.

from [Xen patchbot -unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] Don't leak memory when realloc fails.
From:	Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Wed, 07 Sep 2005 21:34:11 +0000
Delivery-date:	Wed, 07 Sep 2005 21:32:41 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User cl349@xxxxxxxxxxxxxxxxxxxx
# Node ID c2f3f18c0d959bfdcb55828a8e387e784948ab34
# Parent  7d0fb56b4a916cccc497d200e6a8329537ce740d
Don't leak memory when realloc fails.
Signed-off-by: Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>

diff -r 7d0fb56b4a91 -r c2f3f18c0d95 tools/console/daemon/io.c
--- a/tools/console/daemon/io.c Wed Sep  7 19:01:31 2005
+++ b/tools/console/daemon/io.c Wed Sep  7 19:13:38 2005
@@ -279,6 +279,7 @@
 static struct domain *create_domain(int domid)
 {
        struct domain *dom;
+       char *s;
 
        dom = (struct domain *)malloc(sizeof(struct domain));
        if (dom == NULL) {
@@ -306,10 +307,11 @@
        dom->conspath = xs_get_domain_path(xs, dom->domid);
        if (dom->conspath == NULL)
                goto out;
-       dom->conspath = realloc(dom->conspath, strlen(dom->conspath) +
-                               strlen("/console") + 1);
-       if (dom->conspath == NULL)
+       s = realloc(dom->conspath, strlen(dom->conspath) +
+                   strlen("/console") + 1);
+       if (s == NULL)
                goto out;
+       dom->conspath = s;
        strcat(dom->conspath, "/console");
 
        if (!watch_domain(dom, true))

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] Don't leak memory when realloc fails., Xen patchbot -unstable <=

Previous by Date:	[Xen-changelog] Create /dev/xen/evtchn if it doesn't exist., Xen patchbot -unstable
Next by Date:	[Xen-changelog] Disable sync dbmap saves -- they remove nodes added by other tools., Xen patchbot -unstable
Previous by Thread:	[Xen-changelog] Create /dev/xen/evtchn if it doesn't exist., Xen patchbot -unstable
Next by Thread:	[Xen-changelog] Disable sync dbmap saves -- they remove nodes added by other tools., Xen patchbot -unstable
Indexes:	[Date] [Thread] [Top] [All Lists]