[Xen-bugs] [Bug 1429] New: XSM-ACM module not working on Xen 3.3.1

[bugzilla-daemon@xxxxxxxxxxxxxxxxxxx]

http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1429

           Summary: XSM-ACM module not working on Xen 3.3.1
           Product: Xen
           Version: 3.0 (general)
          Platform: x86-64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: amazab@xxxxxxxx


I followed the manual to initialize XSM-ACM module on Xen3.3.1-64 bit. However,
whenever I used "xm get policy". Xen tools could not detect the DEFAULT policy
installed and reports it as "None". Of course, this affects all other ACM
functions like setpolicy, resetpolicy, etc...

I traced the code, I found that the default ACM policy starts correctly inside
then however, the problem is in the file "tools/python/xen/lowlevel/acm/acm.c".
Function "__getssid", which is supposed to get the domain's SSID and hence
determine the used policy erases the retrieved buffer in the case of success.
The faulty lines are number 70 & 71 (in Version 3.3.1). If the return is Null,
the calling function will assume that no policy is installed and hence disable
any further ACM operations!


The if condition is as follows:

    if (xc_acm_op(xc_handle, ACMOP_getssid, &getssid, sizeof(getssid)) < 0) {
        if (errno == EACCES)
            PERROR("ACM operation failed.");
        free(buf);
        buf = NULL;
        goto out2;
    } else {
        *buflen = SSID_BUFFER_SIZE;
        free(buf);
        buf = NULL;
        goto out2;
    }

In the case of an "else" the two lines 
        free(buf);
        buf = NULL;
Should be omitted!!

Ahmed


-- 
Configure bugmail: 
http://bugzilla.xensource.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

_______________________________________________
Xen-bugs mailing list
Xen-bugs@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-bugs