[Xen-API] Re: [PATCH] Use correct upstream name for /dev/xen/evtchn

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2010-02-15 at 17:21 +0000, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1266254439 0
> # Node ID b3ba3aa3e0e9dfd9ae5769583ec4728ded5e564c
> # Parent  fe4cae1a911111d826b599362464ec894f2fc437
> Use correct upstream name for /dev/xen/evtchn.
> 
> This name has been upstream since forever and the typo here was
> leaving us with two device nodes.
> 
> It's debatable whether this code should be trying to mknod the device
> in any case, it should always be present.

Actually, the assumption here that the evtchn device has minor 63  is
faulty since the driver actually requests MISC_DYNAMIC_MINOR which could
give a random answer. Follow up patch to, err, follow...

> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> diff -r fe4cae1a9111 -r b3ba3aa3e0e9 eventchn/eventchn_stubs.c
> --- a/eventchn/eventchn_stubs.c       Mon Jan 25 12:06:20 2010 +0000
> +++ b/eventchn/eventchn_stubs.c       Mon Feb 15 17:20:39 2010 +0000
> @@ -41,7 +41,7 @@
>  #include <caml/callback.h>
>  #include <caml/fail.h>
>  
> -#define EVENTCHN_PATH "/dev/xen/eventchn"
> +#define EVENTCHN_PATH "/dev/xen/evtchn"
>  #define EVENTCHN_MAJOR 10
>  #define EVENTCHN_MINOR 63
>  



_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api