WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-api

[Xen-API] [PATCH] CA-30393: block extauth-enable if there are duplicate

To: xen-api <xen-api@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-API] [PATCH] CA-30393: block extauth-enable if there are duplicate hostnames in the pool
From: Marcus Granado <marcus.granado@xxxxxxxxxx>
Date: Thu, 3 Dec 2009 18:14:28 +0000
Delivery-date: Thu, 03 Dec 2009 10:15:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
1 file changed, 14 insertions(+)
ocaml/xapi/xapi_pool.ml |   14 ++++++++++++++


# HG changeset patch
# User Marcus Granado <marcus.granado@xxxxxxxxxx>
# Date 1259863960 0
# Node ID f9617197a99bc47e7bf4f12df6a6fe15dc990aa5
# Parent  8335acd2219af19c6345d349690679dac2f5953a
CA-30393: block extauth-enable if there are duplicate hostnames in the pool

Signed-off-by: Marcus Granado <marcus.granado@xxxxxxxxxxxxx>

diff -r 8335acd2219a -r f9617197a99b ocaml/xapi/xapi_pool.ml
--- a/ocaml/xapi/xapi_pool.ml   Thu Dec 03 15:33:34 2009 +0000
+++ b/ocaml/xapi/xapi_pool.ml   Thu Dec 03 18:12:40 2009 +0000
@@ -1066,6 +1066,20 @@
                end
        with Not_found -> () (* that's expected, no host had external_auth 
enabled*)
        ;
+       (* 1b. assert that there are no duplicate hostnames in the pool *)
+       if (List.length hosts)
+               <>
+               (List.length
+                        (Listext.List.setify 
+                                       (List.map (fun h->Db.Host.get_hostname 
~__context ~self:h) hosts))
+               )
+       then begin
+               let errmsg = "At least two hosts in the pool have the same 
hostname" in
+               debug "%s" errmsg;
+               raise 
(Api_errors.Server_error(Api_errors.pool_auth_enable_failed,
+                       [(Ref.string_of (List.hd hosts));errmsg]))
+       end
+       else
        (* 2. tries to enable the external authentication in each host of the 
pool *)
        let host_error_msg = ref ("","","") in
        let rollback_list = 

Attachment: xen-api.hg.patch
Description: Text Data

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api
<Prev in Thread] Current Thread [Next in Thread>