WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xense-devel

[Xen-devel] Re: [PATCH] txt: 6/6 - hypervisor integrity on S3

To: "Cihula, Joseph" <joseph.cihula@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>, <xense-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] txt: 6/6 - hypervisor integrity on S3
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 20 Jan 2009 09:05:32 +0000
Cc: "Wang, Shane" <shane.wang@xxxxxxxxx>
Delivery-date: Tue, 20 Jan 2009 01:07:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4F65016F6CB04E49BFFA15D4F7B798D92D62976E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acl6wwDVeGb+gD7oQVWBnioT1hmixwAGz50w
Thread-topic: [PATCH] txt: 6/6 - hypervisor integrity on S3
User-agent: Microsoft-Entourage/12.15.0.081119
On 20/01/2009 05:50, "Cihula, Joseph" <joseph.cihula@xxxxxxxxx> wrote:

> When launched from tboot, utilise tboot interface to provide integrity
> protection to the hypervisor during S3
> 
> Signed-off-by: Joseph Cihula <joseph.cihula@xxxxxxxxx>
> ACKed-by: Shane Wang <shane.wang@xxxxxxxxx>
> 
> +        g_tboot_shared->mac_regions[1].start = (uint64_t)xen_phys_start;
> +        g_tboot_shared->mac_regions[1].end = (uint64_t)xenheap_phys_end;
> +    }

Looks like the only place you use the xen_phys_start and xenheap_phys_end.
Of course xenheap_phys_* no longer even exist on x86/64. The best you can do
I think is [__pa(&_start), __pa(&_end)]. If you want to do better for i386
(though frankly hardly anyone uses that build) then you can use
[xenheap_phys_start, xenheap_phys_end] and update xenheap_phys_start to
(1ul<<20) in setup.c. Please leave xen_phys_start alone and don't use it.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>