WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-users

[Xen-users] Re: [Xen-devel] Xen GCOV Patches for latest Xen Unbstable an

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-users] Re: [Xen-devel] Xen GCOV Patches for latest Xen Unbstable and linux 2.6.18.8 kernel(32/64bit)
From: Tej <bewith.tej@xxxxxxxxx>
Date: Mon, 10 May 2010 22:56:49 +0530
Cc: George Dunlap <george.dunlap@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-users <xen-users@xxxxxxxxxxxxxxxxxxx>, parkash.tej@xxxxxxxxx
Delivery-date: Mon, 10 May 2010 10:28:18 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=iiuEKbkI+0kPdvgofpECrOGlk/FDBBQB2okwgyfoWRs=; b=ciYWoVYYwZ/SnBG0DiaOF111UF0Z/EmPZSJ+K8PxoEgGCTV0aqAIU5Wy4VLeIc76zj Uskw+Njzr8N71x0FBKY+3E2eUku24TCknt+1W5QAniY2X/LVwphXHjkJ2llXyAsB3C08 Yc1wcGwp5lJcMaHXTrQno9lrxKN7iG6Q/BSuQ=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=bdMvpqwYyCyd2nFr5nHXDrjDvpyP1DMXpntbuLNPlxorf543ZdZuRwEUmtFqA5+yp8 WiT4pwtdf46koUgbxt/BYO/BvbSYF9QhxYVoFjBZqiz49NV9ScBmqw6CJw4NOSTsfMNC KeAIEBgpg/DQCft9yWzVxOe8cK+8PU/XU+s/Q=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100510145312.GE29517@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-users-request@lists.xensource.com?subject=help>
List-id: Xen user discussion <xen-users.lists.xensource.com>
List-post: <mailto:xen-users@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=unsubscribe>
References: <o2jf1c9d251005071301jfd33f723gc49e4013ae4a3d47@xxxxxxxxxxxxxx> <20100510145312.GE29517@xxxxxxxxxxxxxxxxxxx>
Sender: xen-users-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, May 10, 2010 at 8:23 PM, Konrad Rzeszutek Wilk
<konrad.wilk@xxxxxxxxxx> wrote:
> On Sat, May 08, 2010 at 01:31:01AM +0530, Tej wrote:
>> All,
>>
>> Here are the latest patches to expreiment with gcov profiler for xen
>> hypervisor. I have tested current patches on Intel i686.
>
> Nice..
>
>> System Details:
>> gcc version 4.3.3 (Ubuntu 4.3.3-5ubuntu4)
>> gcov (Ubuntu 4.3.3-5ubuntu4) 4.3.3
>> Kernel 2.6.28-11-generic
>
> Uhh? 2.6.28 or 2.6.18?
>
> I hate to tell you this but development is happening in the pv-ops
> kernel, not anymore in the XenLinux branches :-(
>
> Any chance you can rebase those patches against the pv-ops kernel?
>
> Looking briefly at the Linux patches, you need to remove those #ifdef
> LINUX_VERSION_CODE, make the EXPORT_SYMBOL be EXPORT_SYMBOL_GPL, and
> also run the patch through scripts/checkpatch.pl

Thanks for your review/suggestion, will do all and get back but may be
after 2 weeks as i am off from the work, (only mails)

>> Distribution: Ubuntu jaunty 9.04
>>
>> There are some design issue which i would like to highlight here:
>> 1. To create gcov proc dir user /proc/xen, we are explicitly exported
>> xen_base symbol. I want to know your thoughts.
>> 2. XEN_GCOV_PROC config is set as not selected. So someone has to be
>> configured manually as M/Y
>>
>>
>> Known Issues:
>> File vmac.c throw some fault while using with lcov/gcov. This is due
>> to some raw count copy between xen and kernel. I could not able to
>> reproduce it many times, may be someone can try on 64 bit m/c.
>> "My take on this is that zero length array element in gcov_info
>> structure has to be copied separately between xen and kernel. How? I
>> dont know."
>>
>> I am still debugging this issue.
>>
>> If you get fault and fail to proceed please apply the above patch in
>> linux-wa-v1.patch in Linux 2.6.18.8 and recompile. This time vmac.gcda
>> file wont appear in /proc/xen/gcov/crypto
>>
>>
>> HOWTO Test using lcov
>> 1.  install lcov from repo
>>      # sudo apt-get install lcov
>> 2. vi /etc/lcovrc
>>     Change line: lcov_gcov_dir = /proc/gcov to lcov_gcov_dir = /proc/xen/gcov
>> 3. # cd  /tmp; lcov -c -o kernel.info
>> 4. # genhtml kernel.info
>> 5, # firefox index.html
>>
>> lcov README and screenshot is attached.
>
> 22% coverege, eh? Is that just by booting the Dom0 kernel?

Yes, but any operation on Xen which will reach to hypervisor is going
to change this number, since boot.

>
>>
>> HTH
>>
>> Note:
>> For any other detail required please CC me to parkash.tej@xxxxxxxxx
>
>> diff -r 86d6c6417cf9 drivers/xen/Kconfig
>> --- a/drivers/xen/Kconfig     Thu Feb 04 13:08:27 2010 +0000
>> +++ b/drivers/xen/Kconfig     Sun Feb 07 00:13:40 2010 +0530
>> @@ -311,6 +311,13 @@
>>       help
>>         Xen hypervisor attributes will show up under /sys/hypervisor/.
>>
>> +config XEN_GCOV_PROC
>> +       tristate "Code covarage for hypervisor"
>                          ^^^^^ - coverage

oops!!!!!! thanks for spotting the typo

>

-Tej

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users