 Home |
Products |
Support |
Community |
News |
xen-tools
[Xen-tools] Re: [PATCH] Add a size parameter to xs_read_watch
| To: | Anthony Liguori <aliguori@xxxxxxxxxx> |
|---|---|
| Subject: | [Xen-tools] Re: [PATCH] Add a size parameter to xs_read_watch |
| From: | Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
| Date: | Mon, 19 Sep 2005 09:21:56 +1000 |
| Cc: | Xen Tools Developers <xen-tools@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Sun, 18 Sep 2005 23:19:30 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <432DC063.90904@xxxxxxxxxx> |
| List-help: | <mailto:xen-tools-request@lists.xensource.com?subject=help> |
| List-id: | Xen control tools developers <xen-tools.lists.xensource.com> |
| List-post: | <mailto:xen-tools@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-tools>, <mailto:xen-tools-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-tools>, <mailto:xen-tools-request@lists.xensource.com?subject=unsubscribe> |
| References: | <432DC063.90904@xxxxxxxxxx> |
| Sender: | xen-tools-bounces@xxxxxxxxxxxxxxxxxxx |
On Sun, 2005-09-18 at 14:30 -0500, Anthony Liguori wrote:
> Hi,
>
> The attached patch adds an (optional) unsigned int * parameter to
> xs_read_watch to make it consistent with xs_read_directory. I've been
> experimenting with automated binding generators for libxenstore and
> returning a char ** with an implicit size makes things quite hairy.
Agreed the interface sucks, however your solution is even stranger. How
about:
char *xs_read_watch(struct xs_handle *h, char **token);
With a similar "only free the return value" rule as currently.
Thanks,
Rusty,
--
A bad analogy is like a leaky screwdriver -- Richard Braakman
_______________________________________________
Xen-tools mailing list
Xen-tools@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-tools
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-tools] [PATCH] Add a size parameter to xs_read_watch, Anthony Liguori |
|---|---|
| Next by Date: | [Xen-tools] Re: [PATCH] Add a size parameter to xs_read_watch, Anthony Liguori |
| Previous by Thread: | [Xen-tools] [PATCH] Add a size parameter to xs_read_watch, Anthony Liguori |
| Next by Thread: | [Xen-tools] Re: [PATCH] Add a size parameter to xs_read_watch, Anthony Liguori |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
