Re: [XenPPC] libvirt bad paddr patch for our hcall.c

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Wed, 2007-07-11 at 14:12 +0200, Christian Ehrhardt wrote:
> I added a new inline function "invalid_endianness" for better readability.
> An invalid address now returns -EINVAL and triggers a WARN_ON().
> If a more sophisticated check is wanted later on like a additional >0x0C 
> or something we can add this there on a central point.
> If we will need it somewhere else in the future we can move it to a header.

Perhaps these messages should be quieted a little:
(XEN) pfn2mfn: Dom[0] pfn 0x3f875eb000000 is not a valid page
(XEN) paddr_to_maddr: Dom:0 bad paddr: 0x3f875eb000000000

It also looks like we need to have the callers of paddr_to_maddr()
(within Xen) do some error-checking and return the error.

However, it isn't the kernel's job to be checking these addresses, so
this patch isn't the right solution.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel