WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [PATCH 1/4] move shared page definitions to public header

To: Ryan Harper <ryanh@xxxxxxxxxx>
Subject: Re: [XenPPC] [PATCH 1/4] move shared page definitions to public header
From: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Date: Wed, 31 Jan 2007 09:08:06 -0500
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 31 Jan 2007 06:07:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070130190800.GA24048@xxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070130190800.GA24048@xxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
No need to respin, since this can wait for a follow-on/dom0 work, we can lose:
+#define RMA_LAST_DOM0 2
+/* these are not used for dom0 so they should be last */
+#define RMA_CONSOLE 3
+#define RMA_STORE 4
+#define RMA_LAST_DOMU 4
Since dom0 does not use them, and
And when dom0 goes flat we can lose the rest.
The domU shared info page can be obtained from XEN_DOMCTL_getdomaininfo

Another option is that we could simply drop this patch all together since the contents will go away.

-JX


On Jan 30, 2007, at 2:08 PM, Ryan Harper wrote:

Move shared page location contract to public header to share with libxc.

--
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx


diffstat output:
 arch/powerpc/domain_build.c   |    1 +
 arch/powerpc/mm.c             |    1 +
 include/asm-powerpc/domain.h  |    7 -------
 include/public/arch-powerpc.h |    8 ++++++++
 4 files changed, 10 insertions(+), 7 deletions(-)

Signed-off-by: Ryan Harper <ryanh@xxxxxxxxxx>
---
diff -r 0980dfbae746 xen/include/asm-powerpc/domain.h
--- a/xen/include/asm-powerpc/domain.h  Thu Jan 25 15:55:25 2007 -0500
+++ b/xen/include/asm-powerpc/domain.h  Mon Jan 29 17:57:52 2007 -0600
@@ -107,13 +107,6 @@ extern void save_float(struct vcpu *);
 extern void save_float(struct vcpu *);
 extern void load_float(struct vcpu *);

-#define RMA_SHARED_INFO 1
-#define RMA_START_INFO 2
-#define RMA_LAST_DOM0 2
-/* these are not used for dom0 so they should be last */
-#define RMA_CONSOLE 3
-#define RMA_LAST_DOMU 3
-
 #define rma_size(rma_order) (1UL << ((rma_order) + PAGE_SHIFT))

 static inline ulong rma_addr(struct arch_domain *ad, int type)
diff -r 0980dfbae746 xen/include/public/arch-powerpc.h
--- a/xen/include/public/arch-powerpc.h Thu Jan 25 15:55:25 2007 -0500
+++ b/xen/include/public/arch-powerpc.h Mon Jan 29 17:57:52 2007 -0600
@@ -117,6 +117,14 @@ struct arch_vcpu_info {
 struct arch_vcpu_info {
 };

+#define RMA_SHARED_INFO 1
+#define RMA_START_INFO 2
+#define RMA_LAST_DOM0 2
+/* these are not used for dom0 so they should be last */
+#define RMA_CONSOLE 3
+#define RMA_STORE 4
+#define RMA_LAST_DOMU 4
+
 /* Support for multi-processor guests. */
 #define MAX_VIRT_CPUS 32
 #endif
diff -r 0980dfbae746 xen/arch/powerpc/domain_build.c
--- a/xen/arch/powerpc/domain_build.c   Thu Jan 25 15:55:25 2007 -0500
+++ b/xen/arch/powerpc/domain_build.c   Mon Jan 29 20:48:09 2007 -0600
@@ -30,6 +30,7 @@
 #include <xen/version.h>
 #include <asm/processor.h>
 #include <asm/papr.h>
+#include <public/arch-powerpc.h>
 #include "oftree.h"

 extern int parseelfimage_32(struct domain_setup_info *dsi);
diff -r 0980dfbae746 xen/arch/powerpc/mm.c
--- a/xen/arch/powerpc/mm.c     Thu Jan 25 15:55:25 2007 -0500
+++ b/xen/arch/powerpc/mm.c     Mon Jan 29 20:47:39 2007 -0600
@@ -28,6 +28,7 @@
 #include <asm/init.h>
 #include <asm/page.h>
 #include <asm/string.h>
+#include <public/arch-powerpc.h>

 #ifdef VERBOSE
 #define MEM_LOG(_f, _a...)                                  \

_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>