WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init

To: Yoder Stuart-B08248 <stuart.yoder@xxxxxxxxxxxxx>
Subject: Re: [XenPPC] [PATCH] fix debug print in boot_of_alloc_init
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 08 Jan 2007 16:54:49 -0600
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 08 Jan 2007 14:54:34 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <9696D7A991D0824DBA8DFAC74A9C5FA30203E8A2@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <9696D7A991D0824DBA8DFAC74A9C5FA30203E8A2@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2007-01-08 at 15:46 -0700, Yoder Stuart-B08248 wrote:
> This is a minor bug in a debug print that most likely will never 
> be seen, as start is typically 0, but it is something I noticed.
> 
> Signed-off-by: Stuart Yoder <stuart.yoder@xxxxxxxxxxxxx>
> 
> 
> diff -r db52c7d043bb xen/arch/powerpc/boot_of.c
> --- a/xen/arch/powerpc/boot_of.c        Tue Dec 19 09:20:58 2006 -0500
> +++ b/xen/arch/powerpc/boot_of.c        Mon Jan 08 16:43:09 2007 -0600
> @@ -419,7 +419,7 @@ static void boot_of_alloc_init(int m, ui
>              start = ALIGN_UP(start, PAGE_SIZE);
> 
>              DBG("%s: marking 0x%x - 0x%lx\n", __func__,
> -                pg << PAGE_SHIFT, start);
> +                pg << PAGE_SHIFT, start << PAGE_SHIFT);
> 
>              start >>= PAGE_SHIFT;
>              while (pg < MEM_AVAILABLE_PAGES && pg < start) {

Thanks Stuart. However, the patch I just sent out an hour ago is going
to remove this code entirely. :)

I haven't checked it in yet though: I'd appreciate it if you could test
it on systemsim, and please let me know if you have any comments as
well.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>