WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [XenPPC][Patch] memory alignment check for allocMem

To: geyi <kudva@xxxxxxxxxxxxxx>
Subject: Re: [XenPPC][Patch] memory alignment check for allocMem
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 20 Nov 2006 14:27:47 -0600
Cc: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 20 Nov 2006 12:28:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4561FE5C.3020501@xxxxxxxxxxxxxx>
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <4561BF3C.60009@xxxxxxxxxxxxxx> <2AF22B20-9239-4781-A7E6-56F3E17D0610@xxxxxxxxxxxxxx> <4561FE5C.3020501@xxxxxxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2006-11-20 at 14:13 -0500, geyi wrote:
> 
> The other one is for _allocMem2, the memory-allocate function for
> domain restore. You can find it in my previous patch.

I've been meaning to say something, but haven't had an opportunity to
really review your patches...

"allocMem2" is a terrible name at least, and at worst is duplicating
code. I am not at all comfortable with that. If we need to refactor
something we can work with the Cambridge guys to do it.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>