Re: [XenPPC][Patch 2/3] xen patches for xm save/restore

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Thu, 2006-11-02 at 11:49 -0500, geyi wrote:
> +    case XEN_DOMCTL_getshadowlist:
> +    {
> +       struct domain *d = find_domain_by_id(domctl->domain);
> +       uint num_ptes;
> +
> +       printk(" XEN_DOMCTL_getshadowlist: \n");
> +
> +       ret = -EINVAL;
> +       if ( d != NULL)
> +       {
> +          ret = 0;
> +
> +          domctl->u.getshadowlist.htab_map = (uint64_t)(d->arch.htab.map);
> +          printk("htab_map: 0x%016lx\n",(uint64_t)(d->arch.htab.map));
> +
> +          num_ptes = 1UL << d->arch.htab.log_num_ptes;
> +          domctl->u.getshadowlist.htab_num_ptes = num_ptes; 

Here you've set htab_map to a machine address. What is the domain
supposed to do with that? Does "save" destroy the domain? Are you
expecting that address to be valid once the domain is destroyed?

The operation is called "getshadowlist", but there is no list here.
Wouldn't a copying a list into a domain-provided buffer make more sense?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel