WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

[XenPPC] small bug in exceptions.S?

To: xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Subject: [XenPPC] small bug in exceptions.S?
From: Mark F Mergen <mergen@xxxxxxxxxx>
Date: Tue, 20 Jun 2006 16:01:02 -0400
Delivery-date: Tue, 20 Jun 2006 13:01:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
Importance: Normal
List-help: <mailto:xen-ppc-devel-request@lists.xensource.com?subject=help>
List-id: Xen PPC development <xen-ppc-devel.lists.xensource.com>
List-post: <mailto:xen-ppc-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ppc-devel>, <mailto:xen-ppc-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ppc-devel-bounces@xxxxxxxxxxxxxxxxxxx
Sensitivity:
I don't have a failure case, but I noticed this while reading code at line
307 in xen/arch/ppc/ppc64/exceptions.S.  It seems to me that this code
doesn't do what the comment says is intended.

    /* clear MSR:RI/EE to set SRR0/SRR1 */
    mfmsr r0
    li r13, 0
    mtmsrd r0, 1

I believe correct code would be:

    li r0,0
    mtmsrd r0, 1

Mark Mergen


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel

<Prev in Thread] Current Thread [Next in Thread>