[XenPPC] Re: [rfc][patch] privcmp from user and kernel

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Tue, 2006-06-06 at 16:08 -0400, Jimi Xenidis wrote:
> Hollis,
> I think I got this right, I need to make the priv hcall available for
> the kernel as well. Does this look right to you?

Looks good, except this one part:

...
> +     case XENMEM_populate_physmap:
> +     case XENMEM_current_reservation:
> +     case XENMEM_maximum_reservation:
> +     case XENMEM_machphys_mfn_list:
> +     case XENMEM_add_to_physmap:
> +     case XENMEM_translate_gpfn_list:

Did you mean to let all these fall through to default? Why not just omit
them, and add them later as we handle them?

> +     default:
> +             printk("%s: unknown grant table op %d\n", __func__, cmd);
>               ret = -ENOSYS;
> -             goto out;
> -     }
...

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-ppc-devel mailing list
Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ppc-devel