 Home |
Products |
Support |
Community |
News |
xen-ppc-devel
Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purpos
On Tue, Apr 25, 2006 at 04:41:08PM -0400, Jimi Xenidis wrote: > > On Apr 25, 2006, at 3:51 PM, Hollis Blanchard wrote: > >Please fix the // comments and spacing mismatch. > oops, yes I hate them to. > > > >Also, I'm completely baffled... why did you add all these magic > >numbers > >instead of simply extending "union hid0"? Please fix. > because they are not necessarily architected bit, so I'd rather leave > them for debug. With the same reasoning the union could be removed, since HID0 layout is unarchitected by definition. -Olof _______________________________________________ Xen-ppc-devel mailing list Xen-ppc-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ppc-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0, Hollis Blanchard |
|---|---|
| Next by Date: | Re: [XenPPC] [pushed] [ppc] FPSCR and XER are really 64 bit quantities, Jimi Xenidis |
| Previous by Thread: | Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0, Hollis Blanchard |
| Next by Thread: | Re: [XenPPC] [pushed] [ppc] serialize the processor for debugging purposes and print out HID0, Jimi Xenidis |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
