[Xen-devel] Re: [PATCH 2/2] ioemu: initialize vram area to 0xff

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

Isaku Yamahata wrote:

> +
> +    xen_vga_vram_map(vram_addr, vga_ram_size);
> +
> +    /* Win2K seems to assume that the pattern buffer is at 0xff
> +       initially ! */
> +    memset(xen_vga_state->vram_ptr, 0xff, vga_ram_size);


Are you sure that this is really needed?
Isn't the Bios supposed to take care of that?

> +    /* If some display is already working, we need to update it now */
> +    ds= xen_vga_state->ds;
> +    if (ds)
> +        dpy_update(ds, 0,0, ds->width,ds->height);


I don't think this is needed as well: xen_vga_vram_map is called either
during the initialization state or when loading the vm state file.
At both points the display shouldn't need any update.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel