WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ia64-devel

[Xen-ia64-devel] [PATCH 3/5] kexec: remove warning.

To: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-ia64-devel] [PATCH 3/5] kexec: remove warning.
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Thu, 24 Jul 2008 14:59:59 +0900
Cc: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Delivery-date: Wed, 23 Jul 2008 22:58:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
[IA64] remove warning.

This patch removes the following warning.

> linux-2.6.18-xen.hg/arch/ia64/kernel/efi.c: In function 
> 'efi_initialize_iomem_machine_resources':
> linux-2.6.18-xen.hg/arch/ia64/kernel/efi.c:1185: warning: control reaches end 
> of non-void function

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff -r 8a3dc4fdb478 arch/ia64/kernel/efi.c
--- a/arch/ia64/kernel/efi.c    Tue Jul 22 11:59:42 2008 +0100
+++ b/arch/ia64/kernel/efi.c    Thu Jul 24 14:31:08 2008 +0900
@@ -1149,7 +1149,7 @@
 }
 
 #ifdef CONFIG_PROC_IOMEM_MACHINE
-static int
+static void
 efi_initialize_iomem_machine_resources(void)
 {
        unsigned long size;
@@ -1163,7 +1163,7 @@
        for (size = 1024; 1; size += 1024) {
                memmap_info = kmalloc(size, GFP_KERNEL);
                if (memmap_info == NULL)
-                       return -ENOMEM;
+                       return; /* -ENOMEM, but no way to return error */
 
                memmap.nr_entries = size;
                set_xen_guest_handle(memmap.buffer, memmap_info);

Attachment: remove-efi-c-warning.patch
Description: Text Data

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel
<Prev in Thread] Current Thread [Next in Thread>