 Home |
Products |
Support |
Community |
News |
xen-ia64-devel
[Xen-ia64-devel] [Patch] [RFC] barrier in xen_rsm_i
| To: | xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-ia64-devel] [Patch] [RFC] barrier in xen_rsm_i |
| From: | Akio Takebe <takebe_akio@xxxxxxxxxxxxxx> |
| Date: | Wed, 12 Dec 2007 23:23:04 +0900 |
| Delivery-date: | Wed, 12 Dec 2007 06:21:26 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help> |
| List-id: | Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com> |
| List-post: | <mailto:xen-ia64-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hi,
xen_ssm_i() has barrier() after xen_set_virtual_psr_i().
I think xen_rsm_i() also need barrier().
Is this correct?
Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
Best Regards,
Akio Takebe
diff -r b865b15fb54b include/asm-ia64/xen/privop.h
--- a/include/asm-ia64/xen/privop.h Mon Dec 10 15:04:49 2007 +0000
+++ b/include/asm-ia64/xen/privop.h Wed Dec 12 23:18:00 2007 +0900
@@ -229,7 +229,10 @@ extern void xen_set_eflag(unsigned long)
/* turning off interrupts can be paravirtualized simply by writing
* to a memory-mapped virtual psr.i bit (implemented as a 16-bit bool) */
-#define xen_rsm_i() xen_set_virtual_psr_i(0)
+#define xen_rsm_i() \
+{ xen_set_virtual_psr_i(0); \
+ barrier(); \
+}
/* turning on interrupts is a bit more complicated.. write to the
* memory-mapped virtual psr.i bit first (to avoid race condition),
_______________________________________________ Xen-ia64-devel mailing list Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-ia64-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-ia64-devel] [PATCH 0/6] xenoprof: various fixes for correct sampling, Isaku Yamahata |
|---|---|
| Next by Date: | Re: [Xen-ia64-devel] [PATCH] Fix vulnerability of copy_to_user in PAL emulation, Alex Williamson |
| Previous by Thread: | [Xen-ia64-devel] [PATCH] Fix TLB purge and reload for xen heap in MCA handler, SUZUKI Kazuhiro |
| Next by Thread: | [Xen-devel] Please pull ia64 trees, Alex Williamson |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
